-
Notifications
You must be signed in to change notification settings - Fork 22
Don't allow child scripts to manipulate terminal #227
Conversation
Since we're not connecting the
We essentially have to create a terminal program that has a virtual terminal and manage that virtual terminal when resizing and flexing. |
how bout goinginto the code of strip-ansi.. and ONLY removing whatever the "clear window" characters are |
That might work ¯_(ツ)_/¯ These are the chars @RaeesBhatti https://github.com/facebook/create-react-app/pull/6632/files#diff-2062ac0fbce6613dbaae936c4f6446afR15 |
well sheet is it that easy |
Even if I don't call
To have any kind of control over the output means that |
I've completely removed |
Found a way to fix this, but seems like I've lost write access to this repo. |
037bd17
to
24908b9
Compare
- Summary
create-react-app
script was using ANSI to clear the screen before we could display our own information. This change disables the handing over of terminal to child script, and buffering output from it. Whencreate-react-app
detects that it is not attached to a terminal, it does not clear screen.Fixes: netlify/cli#374
- Test plan
npx create-react-app my-new-cra
cd my-new-cra
netlify dev
Before:


After:
- Description for the changelog
stdout
andstderr
from child scripts to terminal- A picture of a cute animal (not mandatory but encouraged)
